GIMP Plugin Registry

I tried your Windows binary, pucelo, then I recompiled it without console windows and debug code (100 Mb instead of 500).

I had to modify the .Po files in .deps for they all refer to an H:/ drive in your machine ;)

Well, it works, but there is still the same bug as in the original version (indeed, I did not see the differences: exactly same executable size and same behavior, but I didn't try for a long time):

In both versions the compression rate slider is set to 100. If you save the image without moving it, it makes a gray empty image. If you move the slider and go back to 100 it makes a very compressed yet not so bad image: a 3.5 Mb lossless JP2 is saved as a 90 Kb file.

I initialized the compression rate so that you need not to move the slider, but I haven't done C programming for 15 years, and I never was a good C programmer. I added one line here:

/* Get other parameters from interface */
parameters.numresolution = 6;
rate = 0;
dialog(&rate);
parameters.tcp_rates[0] = rate;

The bug seems to be fixed (image size with zero rate seems to be almost the same size as my lossless test image), but I'm afraid I should have initialized the variable elsewhere, since I forgot almost everything about C...

[Edited]

I also noticed that if I wanted to type the JP2 extension in uppercase, the plugin would crash. So I added:

static const char *extension[] =
{ "pgx", "pnm", "pgm", "ppm", "bmp", "j2k", "jp2", "jpt", "PGX", "PNM", "PGM", "PPM", "BMP", "J2K", "JP2", "JPT" };

Not very proud of this (if someone writes "Jp2", I suppose it will crash, too.

As for the rate statement, I finally wrote:
if (rate < 0 || rate > 100) rate = 0;

But the slider always starts at zero, which proves that the variable is out of bounds every time the program starts.

I retrieved my old C reference manual, mouldy, ill-smelling, dated 1990...

[...later] I read one page of the ill-smelling manual, and I removed my uppercase constants. Just wrote:
if (strnicmp (ext, extension[i], 3) == 0)
instead of
if (strncmp (ext, extension[i], 3) == 0)
Same issue in jp2read. Same remedy.

François Collard